Bug 282625
| Summary: | [resultsdbpy] Fix _find() method in commit_controller.py return amount to abide by the limit amount passed. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anfernee Viduya <aviduya> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 282666 | ||
| Bug Blocks: | |||
Anfernee Viduya
ISSUE:
Right now when invoking _find() method in commit_controller.py with an explicit limit argument it returns the (limit*amount_of_repositories) amount.
This only works if amount_of_repositories = 1.
(e.g.)
'''
LIMIT = 1000
def _find(LIMIT):
...
commits*amount_of_repositories
return sorted(list(commits))
'''
FIX:
Slice the list that was returned outside the 'sorted()' method
(e.g.)
'''
LIMIT = 1000
def _find(LIMIT):
....
commits*amount_of_repositories
return sorted(list(commits))[:limit]
'''
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139298383>
Anfernee Viduya
Pull request: https://github.com/WebKit/WebKit/pull/36206
EWS
Committed 286184@main (74589224e4a9): <https://commits.webkit.org/286184@main>
Reviewed commits have been landed. Closing PR #36206 and removing active labels.
Ben Schwartz
Reopened Bugzilla.
Unreviewed revert of 286184@main, broke tooling., tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282666.
Anfernee Viduya
Pull request: https://github.com/WebKit/WebKit/pull/36267