Bug 28261

Summary: REGRESSION(r47175): error running run-webkit-tests
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch v1 none

Description Eric Seidel (no email) 2009-08-13 09:30:57 PDT 
Use of uninitialized value in concatenation (.) or string at WebKitTools/Scripts/run-webkit-tests line 191.

I have a fix.
Comment 1 Eric Seidel (no email) 2009-08-13 09:32:49 PDT 
Created attachment 34750 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-08-13 09:33:31 PDT 
It was being used in the $usage string before being set.
Comment 3 Eric Seidel (no email) 2009-08-13 10:59:33 PDT 
Comment on attachment 34750 [details]
Patch v1

Rejecting patch 34750 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 4 David Kilzer (:ddkilzer) 2009-08-13 11:00:22 PDT 
(In reply to comment #0)
> Use of uninitialized value in concatenation (.) or string at
> WebKitTools/Scripts/run-webkit-tests line 191.

*sigh*  I should just stop working on tools.  My record hasn't been very good recently.
Comment 5 Eric Seidel (no email) 2009-08-13 11:01:55 PDT 
Comment on attachment 34750 [details]
Patch v1

Sigh.  a checkin happend right as bugzilla-tool was about to land this.  adding it back to the queue.
Comment 6 Eric Seidel (no email) 2009-08-13 11:02:34 PDT 
(In reply to comment #4)
> (In reply to comment #0)
> > Use of uninitialized value in concatenation (.) or string at
> > WebKitTools/Scripts/run-webkit-tests line 191.
> 
> *sigh*  I should just stop working on tools.  My record hasn't been very good
> recently.

I would be very sad were that to be the case!  We just need to get you hackin on the python stuff which is actually unit-testable. :)
Comment 7 Eric Seidel (no email) 2009-08-13 11:14:01 PDT 
Comment on attachment 34750 [details]
Patch v1

Rejecting patch 34750 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'dcommit']"  exit_code: 1  cwd: None
Comment 8 Eric Seidel (no email) 2009-08-13 11:35:03 PDT 
Comment on attachment 34750 [details]
Patch v1

Clearing flags on attachment: 34750

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
Committed r47223
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/run-webkit-tests
r47223 = f1aeff7782adc69b65427803575711023b57ada0 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47223
Comment 9 Eric Seidel (no email) 2009-08-13 11:35:07 PDT 
All reviewed patches have been landed.  Closing bug.