Bug 282535
| Summary: | [WPE][GTK][WTF] Add support for tracing counters with Sysprof | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Georges Basile Stavracas Neto <feaneron> |
| Component: | WPE WebKit | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Georges Basile Stavracas Neto
This allows e.g. monitoring how many buffers are on flight, or the FPS over time.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Georges Basile Stavracas Neto
Pull request: https://github.com/WebKit/WebKit/pull/36123
EWS
Committed 293020@main (e812b451c525): <https://commits.webkit.org/293020@main>
Reviewed commits have been landed. Closing PR #36123 and removing active labels.
Diego Pino
The patch caused a build error on Debian and Ubuntu post-commit bots:
https://build.webkit.org/#/builders/46/builds/49508
```
from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:56,
from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-15db4ad9-9.cpp:7:
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WTF/Headers/wtf/glib/SysprofAnnotator.h: In member function ‘void WTF::SysprofAnnotator::setCounter(std::span<const char>, int64_t)’:
/home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WTF/Headers/wtf/glib/SysprofAnnotator.h:265:13: error: ‘strlcpy’ was not declared in this scope; did you mean ‘strncpy’?
265 | strlcpy(counter.category, m_processName.characters(), sizeof counter.category);
| ^~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/43453
EWS
Committed 293090@main (37790f401c18): <https://commits.webkit.org/293090@main>
Reviewed commits have been landed. Closing PR #43453 and removing active labels.