Bug 282458
| Summary: | [webkitpy] SimulatedDeviceManager.initialize_devices is not preferring booted simulators. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Schwartz <ben_schwartz> |
| Component: | Tools / Tests | Assignee: | Ben Schwartz <ben_schwartz> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, a_protyasha, jbedard, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Schwartz
The changes at 285830@main added support for specifying the UDID(s) of the desired simulators to use when invoking run-webkit-tests. As part of this change, the flow of choosing which device to use changed to be: 1) explicitly requested by user (--udid flag), 2) already booted, 3) already created non-booted, and 4) create new. A logical error caused booted devices not to be preferred, favoring the devices in alphabetical order instead. This should be changed to reflect the desired behavior.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139092301>
Ben Schwartz
Pull request: https://github.com/WebKit/WebKit/pull/36059
EWS
Committed 286040@main (3dc7935d008b): <https://commits.webkit.org/286040@main>
Reviewed commits have been landed. Closing PR #36059 and removing active labels.