Bug 282406
| Summary: | Enable -Wunsafe-buffer-usage in WebCore | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | WebKit Misc. | Assignee: | Geoffrey Garen <ggaren> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 282497 | ||
| Bug Blocks: | |||
Geoffrey Garen
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
<rdar://problem/137810622>
Geoffrey Garen
Pull request: https://github.com/WebKit/WebKit/pull/36014
EWS
Committed 286031@main (67602317a964): <https://commits.webkit.org/286031@main>
Reviewed commits have been landed. Closing PR #36014 and removing active labels.
Ryosuke Niwa
Looks like this broke builds on safer C++ bots?
Source/WebCore/crypto/cocoa/CryptoAlgorithmEd25519Cocoa.cpp:54:28: error: the two-parameter std::span construction is unsafe as it can introduce mismatch between buffer size and the bound information [-Werror,-Wunsafe-buffer-usage-in-container]
54 | return Vector<uint8_t>(std::span { newSignature, ed25519SignatureSize });
| ^
error: unsafe pointer operation [-Werror,-Wunsafe-buffer-usage]
note: pass -fsafe-buffer-usage-suggestions to receive code hardening suggestions
2 errors generated.
Geoffrey Garen
Oh, that must be the #if !HAVE(SWIFT_CPP_INTEROP) config. Fixing....
Geoffrey Garen
Trying out a fix in https://github.com/WebKit/WebKit/pull/36082
Jonathan Bedard
Reopened Bugzilla.
REGRESSION(286031@main): Broke Internal iOS and visionOS Debug builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=282497.