Bug 28239
| Summary: | bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode
It should not cq- minus patches when not in commit-queue mode.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
Sorry. I should caught that when reviewing the earlier change.
Eric Seidel (no email)
I'm not sure which circumstances produce this bug, making it difficult to fix. Should patches not be cq-'d when a build fails and you're not in commit mode? If not, we just need to conditionalize:
except ScriptError, e:
# Mark the patch as commit-queue- and comment in the bug.
tool.bugs.reject_patch_from_commit_queue(patch['id'], e.message_with_output())
error(e)
in LandPatchesFromBugs.land_patches
Eric Seidel (no email)
I've not seen this in a long time.