Bug 28231 – Inspector Resource filtering: keyboard Navigation always uses ALL resources

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Tak]

+++ This bug was initially created as a clone of Bug #20629 +++

It'd be nice for the Inspector | Resources Graph panel to support filtering by various things.

++++

Thanks for the commit, enjoying it already!

However.....

Once you have a complex page loaded (with lots of different type entries) and the filter has been applied, the keyboard shortcuts that allow you to scroll thru the resources are still scrolling thru the "all" list instead of the filtered list.

example:

1. Open nightly build of webkit, open Resources tab
2. http://nightly.webkit.org/
3. Note that there are (currently, aug 2009) nine resources displayed ( a CSS file, a few PNG, an ico and the HTML).
4. Confirm the filter is set to ALL
5. Use the keyboard UP/DOWN key to navigate thru the list of resources  (works well)
6. Enable the filter for IMAGES (seems to work, only images shown)
7. Use the cursor UP/DOWN keys to navigate thru the list

BUG: seems to still scroll thru the original list of 9 resources, even thru the filter for IMAGES is enabled

EXPECTED: only scroll thru the list of IMAGES


Behavior gets pretty erratic once the navigation list has been confused by cursoring thru a filtered list of resources.

[Tak]

Created attachment 34690 [details]
screenshot of label-less resources

extra bonus weirdness if you filter by something that isnt there.

eg: http://nightly.webkit.org/
Filter by FONTS
then cursor up and down the (blank) list, watch as the resources pops in and out of the blank list.

Also managed to get it into a state where the resources names were entirely missing, but the graph was there.

[Tak]

Created attachment 34695 [details]
screenshot of IMAGE filter showing a CSS resources after key navigation

Here's a screenshot of a CSS resources bleeding into the IMAGE filter after keyboarding up and down the list of IMAGE filtered resources.

[Joseph Pecoraro]

Created attachment 34766 [details]
screenshot of IMAGE filter showing CSS Resources after using Search

A resource can also "bleed in" via searching as well.  For example if you're only looking at the images and use the panel search for a string that will appear in an HTML/CSS document, they will bleed in.

[Anthony Ricaud]

Thank you for the report. I think I know how to fix this. But I won't be able to work on it before next week.

[Anthony Ricaud]

Created attachment 34941 [details]
Patch v1

[Anthony Ricaud]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ResourcesPanel.js
Committed r47342
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ResourcesPanel.js
r47342 = 37ea9ef7a424989c0082168086d744e645a4950f (trunk)

[Anthony Ricaud]

The search issue will be tracked under bug 28290