Bug 282274
| Summary: | [GStreamer] VideoSinkCommon: Do not handle events while flushing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alicia Boya García <aboya> |
| Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, calvaris |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alicia Boya García
WebKitVideoSinkProbe has checks for a number of events, namely tag,
allocation and drain.
Events must not be processed during flushes (doing it anyway is a common
source of deadlocks, for example), but there was no check to prevent
that. This patch adds that.
This is a preventive correctness fix and not motivated by any particular
error report.
* Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(WebKitVideoSinkProbe::doProbe):
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alicia Boya García
Pull request: https://github.com/WebKit/WebKit/pull/35951
EWS
Committed 285957@main (6085aa83ce72): <https://commits.webkit.org/285957@main>
Reviewed commits have been landed. Closing PR #35951 and removing active labels.