Bug 282141
| Summary: | Suppress local variable smart pointer warning for ScriptExecutionContext in JS*Callback | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Bindings | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Suppress the warning that ScriptExecutionContext needs to be a RefPtr.
Here, we may or may not be in the context thread and we can't use RefPtr
since ScriptExecutionContext is never thread safe ref-counted.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/35760
Ryosuke Niwa
<rdar://problem/138534253>
EWS
Committed 285740@main (e00595f35d49): <https://commits.webkit.org/285740@main>
Reviewed commits have been landed. Closing PR #35760 and removing active labels.
Ryosuke Niwa
(In reply to Ryosuke Niwa from comment #2)
> <rdar://problem/138534253>
Not sure what happened here. This radar is clearly nothing to do with this PR.
Ryosuke Niwa
Re-opening for pull request https://github.com/WebKit/WebKit/pull/35774
EWS
Committed 285744@main (c1aec0509161): <https://commits.webkit.org/285744@main>
Reviewed commits have been landed. Closing PR #35774 and removing active labels.