Bug 282123
| Summary: | [bmalloc] Gigacage::Kind should be an `enum class` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | bmalloc | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://138671348
Right now if you accidentally call bmalloc::heapKind with an int as your kind, C++ will happily coerce it to a Gigacage::Kind and do weird things thereafter. Changing Gigacage::Kind to an `enum class` avoids this problem.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/35795
EWS
Committed 285829@main (cd44912a57e9): <https://commits.webkit.org/285829@main>
Reviewed commits have been landed. Closing PR #35795 and removing active labels.