Bug 282067
| Summary: | [JSC] Remove outdated FIXME in JSDOMConvertDate.h | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ian Grunert <ian.grunert> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ian Grunert
In JSDOMConvertDate there's a fixme:
// FIXME: This should be taking a JSDOMGlobalObject and passing it to jsDate.
which is confusing because it's taking a JSC::JSGlobalObject& lexicalGlobalObject, and it's unclear why a JSDOMGlobalObject would be better.
The reason for the FIXME appears to be that this function used to accept a JSC::ExecState& state - but in bug 202392 we switched away from that. So it looks like we just forgot to remove the FIXME when we made the relevant change.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ian Grunert
Pull request: https://github.com/WebKit/WebKit/pull/35695
EWS
Committed 285746@main (45b4d89d301b): <https://commits.webkit.org/285746@main>
Reviewed commits have been landed. Closing PR #35695 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/138730190>