|Summary:||REGRESSION: run-webkit-tests --quiet hangs|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Eric Seidel (no email) 2009-08-11 16:49:13 PDT
run-webkit-tests --quiet hangs My perl-fu is not strong. :(
Comment 1 Eric Seidel (no email) 2009-08-11 16:49:35 PDT
I talked this out with "buu" in #perl, and this was the best we came up with.
Comment 2 Eric Seidel (no email) 2009-08-11 16:50:50 PDT
Created attachment 34614 [details] Patch v1
Comment 3 Eric Seidel (no email) 2009-08-12 09:11:44 PDT
I'm going to check this in w/o review to fix the regression that --quiet now hangs. (Alternatively I could roll out my other patch which caused it to hang.) If anyone has suggestions as to how I should improve this code, I'm happy to change it further. This code is specifically trying to avoid turning the args array back into a string. Perl doesn't seem to have an elegant way to deal with an args array *and* route stderr to /dev/null. Another way I could handle this would be to override the parent's stdout/stderr before running the normal "system" call. But that's also pretty nasty (although slightly less code).
Comment 4 Eric Seidel (no email) 2009-08-12 09:17:28 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47109 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47109 = 86eae88a818613b99c22db8d9631abf4c36eca43 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47109