Bug 28198

Summary:

Need to move desktopNotificationsDelegate out of IWebUIDelegate.idl

Product:

WebKit

Reporter:

Andrew Wilson <atwilson>

Component:

WebKit API

Assignee:

John Gregg <johnnyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
refactoring of interfaces	none
refactoring of interfaces	mjs: review+

Andrew Wilson

Reported 2009-08-11 16:04:56 PDT

Per Maciej: othermaciej: new methods should be added to a renamed interface that inherits from the original, like IWebUIDelegate2 othermaciej: and the framework should explicitly check whether that interface is implemented before calling them

Attachments
refactoring of interfaces (9.55 KB, patch) 2009-08-11 17:53 PDT, John Gregg	no flags	Details Formatted Diff Diff
refactoring of interfaces (9.59 KB, patch) 2009-08-11 17:55 PDT, John Gregg	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

John Gregg

Comment 1 2009-08-11 17:53:33 PDT

Created attachment 34622 [details] refactoring of interfaces

John Gregg

Comment 2 2009-08-11 17:55:41 PDT

Created attachment 34624 [details] refactoring of interfaces no tabs this time in my ChangeLog

Andrew Wilson

Comment 3 2009-08-11 18:22:55 PDT

I've added aroben and bdash in case they want to review and/or land the fix themselves, otherwise if someone reviews it I can land it tomorrow when someone is around to babysit the Safari build to make sure this fixes it.

Maciej Stachowiak

Comment 4 2009-08-11 20:22:40 PDT

Comment on attachment 34624 [details] refactoring of interfaces r=me, thanks for fixing, and sorry for overlooking this.

Mark Rowe (bdash)

Comment 5 2009-08-11 20:30:47 PDT

Landed with some style fix-ups in r47084.

Note You need to log in before you can comment on or make changes to this bug.