Summary: | bugzilla-tool: scm module should not import bugzilla module | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, aroben, eric, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Comment on attachment 34505 [details]
Patch v1
Where did the loop go?
Comment on attachment 34505 [details]
Patch v1
The loop went away because it now searches the whole message at once instead of one line at a time.
commit_message.message() vs self.message_lines
And of course, please fix this on commit: http://webkit.org/b/00000 (In reply to comment #3) > And of course, please fix this on commit: http://webkit.org/b/00000 It's already fixed locally. Thanks. $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r47005 http://trac.webkit.org/changeset/47005 |
Created attachment 34505 [details] Patch v1 Reviewed by NOBODY (OOPS!). * Scripts/bugzilla-tool: (parse_bug_id): Added. Moved from CommitMessage.parse_bug_id() in scm module. * Scripts/modules/scm.py: Removed import of bugzilla module. (CommitMessage.parse_bug_id): Deleted. --- 3 files changed, 23 insertions(+), 12 deletions(-)