Bug 281609

Summary:	Make UnixFileDescriptor noncopyable again
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	Web Template Framework	Assignee:	Michael Catanzaro <mcatanzaro>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mattwoodrow, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	PC
OS:	Linux

Michael Catanzaro

Reported 2024-10-16 12:37:16 PDT

Make UnixFileDescriptor noncopyable again. Otherwise, it's very difficult to use the class without accidentally duping the file descriptor. This is a partial revert of 272365@main. We can manually duplicate the file descriptor in the SharedMemoryHandle copy constructor, since we really do want a copy there. This un-reverts 261281@main.

Attachments
Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2024-10-16 12:39:41 PDT

Pull request: https://github.com/WebKit/WebKit/pull/35306

EWS

Comment 2 2024-10-17 07:43:27 PDT

Committed 285336@main (ef66440cf7fc): <https://commits.webkit.org/285336@main> Reviewed commits have been landed. Closing PR #35306 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-10-17 07:44:16 PDT

<rdar://problem/138112700>

Note You need to log in before you can comment on or make changes to this bug.