Bug 28151
| Summary: | KURL hasFragmentIdentifier()/removeFragmentIdentifier() should be cleaned up and made a little smarter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> |
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | abarth, annevk, chinmaya, ddkilzer |
| Priority: | P3 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 37641 | ||
Brady Eidson
KURL hasFragmentIdentifier()/removeFragmentIdentifier() should be cleaned up and made a little smarter.
There's a handful of callsites that always say:
if (someURL.hasFragmentIdentifier())
someURL.removeFragmentIdentifier();
Which is kind of silly and might be cleaner as one line of code...
...except that removeFragmentIdentifier() always allocs a new string and reparses it, when it should really do its own "if I don't have a fragment ID, don't do anything" check.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anne van Kesteren
KURL is gone.