Bug 281412
| Summary: | Change the StringBuilder in stringReplaceAllStringString to RecordOverflow. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
The function was already checking for resultBuilder.hasOverflowed(), but without this RecordOverflow handler being explicitly specified, the StringBuilder will crash eagerly on detected overflow.
rdar://137230737
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/35135
EWS
Committed 285126@main (48e051485568): <https://commits.webkit.org/285126@main>
Reviewed commits have been landed. Closing PR #35135 and removing active labels.
EWS
Committed 283286.290@safari-7620-branch (41ac999f8a8b): <https://commits.webkit.org/283286.290@safari-7620-branch>
Reviewed commits have been landed. Closing PR #2032 and removing active labels.