Bug 28136

Summary: Need to refactor WorkerObjectProxy
Product: WebKit Reporter: Andrew Wilson <atwilson>
Component: WebCore JavaScriptAssignee: Andrew Wilson <atwilson>
Severity: Normal CC: michaeln
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 28170    
Description Flags
proposed patch levin: review+

Description Andrew Wilson 2009-08-09 21:34:00 PDT
Some of the APIs in WorkerObjectProxy are also useful for SharedWorkers - we should refactor the common APIs into a separate class.
Comment 1 Andrew Wilson 2009-08-09 21:52:40 PDT
Created attachment 34439 [details]
proposed patch

This is the first part of my upcoming patch that adds lifecycle management for shared workers.
Comment 2 David Levin 2009-08-11 02:03:19 PDT
Comment on attachment 34439 [details]
proposed patch

> diff --git a/WebCore/workers/WorkerReportingProxy.h b/WebCore/workers/WorkerReportingProxy.h

> +
> +    // APIs used by workers to report console activity.
> +    class WorkerReportingProxy {
> +    public:
> +        virtual ~WorkerReportingProxy() {}
Nice to add a space in the {}
Comment 3 Andrew Wilson 2009-08-11 09:33:47 PDT
Committed as r47036