Bug 28127

Summary: [Haiku] Use Clipboard::create instead of its constructor.
Product: WebKit Reporter: Maxime Simon <simon.maxime>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leavengood
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Use Clipboard::create() instead of the constructor of its class. none

Maxime Simon
Reported 2009-08-09 05:44:23 PDT
Some files are using the constructor of the Clipboard class. Here is a patch to avoid this and use the create() method instead. There is also some style cleanup in ClipboardHaiku.cpp Regards, Maxime
Attachments
Use Clipboard::create() instead of the constructor of its class. (8.18 KB, patch)
2009-08-09 05:51 PDT, Maxime Simon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maxime Simon
Comment 1 2009-08-09 05:51:07 PDT
Created attachment 34415 [details] Use Clipboard::create() instead of the constructor of its class.
Eric Seidel (no email)
Comment 2 2009-08-09 08:08:02 PDT
Comment on attachment 34415 [details] Use Clipboard::create() instead of the constructor of its class. LGTM. Normally we try to split out functional changes from style changes, but this is OK. Thanks for the patch!
Eric Seidel (no email)
Comment 3 2009-08-11 15:25:29 PDT
Comment on attachment 34415 [details] Use Clipboard::create() instead of the constructor of its class. Clearing review flag on attachment: 34415 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp Committed r47068 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47068
Eric Seidel (no email)
Comment 4 2009-08-11 15:25:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.