Bug 281156
| Summary: | [ANGLE] Allow envvar to gate ASSERT at runtime | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | djg, fujii.hironori, kbr, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Add a `ANGLE_ASSERTS_OFF` environment variable that allows us to disable asserts at runtime regardless of how ANGLE was built.
This is necessary due to how some of our build systems work, where we need to be able to disable asserts at runtime regardless of if we built ANGLE with the `ANGLE_ASSERT_ALWAYS_ON` or `ANGLE_ENABLE_ASSERTS` flag set.
We cache the value from the `envvar`, so that we don't incur a `getenv` check on every ASSERT. Additionally, this will not impact release builds as this function is gated by a guard: `#if defined(ANGLE_ENABLE_ASSERTS)`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/137613945>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/34919
Fujii Hironori
FWIW, We have ENABLE_WEBKIT_CONJECTURE_ASSERT env var for WebKit. bug#277938
I don't mean you have to use the same env var.
EWS
Committed 286306@main (0e0d62f0b2e8): <https://commits.webkit.org/286306@main>
Reviewed commits have been landed. Closing PR #34919 and removing active labels.
EWS
Committed 286307@main (aff0b1e3ced7): <https://commits.webkit.org/286307@main>
Reviewed commits have been landed. Closing PR #36353 and removing active labels.