Bug 280975
| Summary: | [libpas] Centralize toggles for libpas debug logging | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Plutowski <marcus_plutowski> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mark.lam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Marcus Plutowski
rdar://137427586
Currently various functions within libpas have little `if (verbose) PAS_LOG(...)` blocks which are quite helpful for understanding what's going on underneath the hood. However, the 'verbose' flags that these functions use are defined inside each function that uses them, so turning groups of them on and off is very annoying. We can keep the existing 'verbose' variables, but it'd be helpful to have a libpas-wide macro (PAS_LOG_LEVEL or PAS_SHOULD_LOG) that would make it easier to turn on and off large groups of these prints at once.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Marcus Plutowski
Pull request: https://github.com/WebKit/WebKit/pull/34775
EWS
Committed 285358@main (dde95ad41f4e): <https://commits.webkit.org/285358@main>
Reviewed commits have been landed. Closing PR #34775 and removing active labels.