Bug 280917

Summary:	Suppress smart pointer warnings on impl objects in auto-generated JS bindings code
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Bindings	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Ryosuke Niwa

Reported 2024-10-04 16:23:26 PDT

Since JS wrapper holds a strong reference to the impl object and JS wrappers are kept alive for the duration of C++ function invocation, it's safe to call into functions without having an aexplicit Ref/RefPtr to the same object in stack.

Attachments
Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2024-10-04 16:27:32 PDT

Pull request: https://github.com/WebKit/WebKit/pull/34725

EWS

Comment 2 2024-10-04 22:41:02 PDT

Committed 284725@main (505f84a26e79): <https://commits.webkit.org/284725@main> Reviewed commits have been landed. Closing PR #34725 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-10-04 22:42:15 PDT

<rdar://problem/137328943>

Note You need to log in before you can comment on or make changes to this bug.