Summary: | [V8] Renamed all NPN_ functions to _NPN_ to match JSC and make them "private" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||
Component: | New Bugs | Assignee: | Jeremy Orlow <jorlow> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, eric, fishd, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Jeremy Orlow
2009-08-07 17:25:19 PDT
Created attachment 34346 [details]
Patch v1
Comment on attachment 34346 [details]
Patch v1
I'm not sure why we have this prefix. But sounds fine to me.
cc'd anders so he sees this go by. In WebKit style if a parameter name doesn't add information in a function declaration, then the name isn't included. For example "identifier" shouldn't be included here: bool _NPN_IdentifierIsString(NPIdentifier identifier); Feel free to clean these up on landing. Sending WebCore/ChangeLog Sending WebCore/bindings/v8/NPV8Object.cpp Sending WebCore/bindings/v8/ScriptController.cpp Sending WebCore/bindings/v8/V8NPObject.cpp Sending WebCore/bindings/v8/V8NPUtils.cpp Sending WebCore/bindings/v8/npruntime.cpp Sending WebCore/bindings/v8/npruntime_impl.h Transmitting file data ....... Committed revision 47021. http://trac.webkit.org/changeset/47021 |