Bug 28077

Summary: [Qt] DumpRenderTree behaves incorrectly when generating test results
Product: WebKit Reporter: George Wright <gwright>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix for dumping PNGs in DRT
eric: review-
Amended changelog manyoso: review+

Description George Wright 2009-08-07 11:40:47 PDT
DumpRenderTree for the Qt port currently only dumps the PNG image data if an expected hash is provided on the commandline. When generating test results, the expected hash is not provided. The Mac port's behaviour differs in that it always dumps the PNG image data unless the expected hash and actual hash match.
Comment 1 George Wright 2009-08-07 11:44:13 PDT
Created attachment 34304 [details]
Fix for dumping PNGs in DRT

Proposed fix.
Comment 2 Eric Seidel (no email) 2009-08-07 11:47:25 PDT
Comment on attachment 34304 [details]
Fix for dumping PNGs in DRT

Specifically, not to dump the images if the hashes match.  Please update the ChangeLog to be more clear.

Otherwise the change looks great!
Comment 3 George Wright 2009-08-07 11:52:28 PDT
Created attachment 34308 [details]
Amended changelog

ChangeLog made more verbose
Comment 4 Adam Barth 2009-08-07 17:53:28 PDT
This patch appears to have already been landed.