Bug 28066

Summary: Avoid using TCmalloc in DumpRenderTree
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27879    
Attachments:
Description Flags
proposed patch darin: review-

Zoltan Horvath
Reported 2009-08-07 04:47:09 PDT
Since Noncopyable'll be inherited from FastAllocBase (and RefCounted has been inherited from Noncopyable), in case of DRT classes using of TCmalloc must be avoided. This change repairs the GTK+'s DRT build fail as well (in case of inheriting Noncopyable from FastAllocBase bug #27879).
Attachments
proposed patch (2.84 KB, patch)
2009-08-07 04:51 PDT, Zoltan Horvath 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-08-07 04:51:31 PDT
Created attachment 34266 [details] proposed patch
Darin Adler
Comment 2 2009-08-07 07:13:47 PDT
Comment on attachment 34266 [details] proposed patch This makes the class name RefCountedCustomAllocated seem pretty bad. After all, there's no desire to "custom allocate" here. I think we should consider doing this with the preprocessor instead of different class names when we're talking about an entirely different binary like DumpRenderTree, since USE_SYSTEM_MALLOC is already set. Can we investigate that instead?
Mark Rowe (bdash)
Comment 3 2009-08-07 16:55:54 PDT
Why are we trying to avoid using FastMalloc from DumpRenderTree? DRT's config.h explicitly includes FastMalloc.h so that uses of operator new will go via fastMalloc.
Zoltan Horvath
Comment 4 2009-08-10 05:46:17 PDT
GTK+ guys solved the build error in r46944 (http://trac.webkit.org/changeset/46944/trunk/WebKitTools/GNUmakefile.am) which caused by Noncopyable's change, so this patch is obsolete.
Note You need to log in before you can comment on or make changes to this bug.