Bug 28055

Summary:

LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

27858

Attachments:

Description	Flags
converts boldSelection.html to a dumpAsText test and adds description.	eric: review+

Description Ryosuke Niwa 2009-08-06 13:47:33 PDT

LayoutTests/editing/styles/boldSelection.html need not be a pixel test because we do not need to test the rendering.  But we must check whether we are adding b or style span.  For this reason, this test must be converted to a dumpAsText.  Furthermore, this test needs description on what it tests.

Comment 1 Ryosuke Niwa 2009-08-06 13:51:41 PDT

The test is under editing/execCommand instead of editing/style.

Comment 2 Ryosuke Niwa 2009-08-06 14:12:33 PDT

Created attachment 34228 [details]
converts boldSelection.html to a dumpAsText test and adds description.

Comment 3 Eric Seidel (no email) 2009-08-06 14:25:08 PDT

Comment on attachment 34228 [details]
converts boldSelection.html to a dumpAsText test and adds description.

Looks great!  Thanks for splitting this out!

Please fix the douplicate when landing:
 var selection = window.getSelection();
 22 var selection = window.getSelection();

Comment 4 Ryosuke Niwa 2009-08-06 14:56:44 PDT

Landed in http://trac.webkit.org/changeset/46860.