Bug 28048 – Place More WinCairo Settings in vsprop files

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Brent Fulgham]

To ease maintenance of the WinCairo port, move several library and compiler flag settings into specific *.vsprops files.

[Brent Fulgham]

Created attachment 34483 [details]
Move some settings into WinCairo/cURL vsprops files.

[Adam Roben (:aroben)]

Comment on attachment 34483 [details]
Move some settings into WinCairo/cURL vsprops files.

> +        * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove
> +          manual flags and library dependencies for WinCairo port.

I think a little more detail would be preferable here, given the difficulty of reading .vcproj diffs.

> -				ForcedIncludeFiles="WebKitPrefix.h"
>  				DisableSpecificWarnings="4819"
> +				ForcedIncludeFiles="WebKitPrefix.h"

I'm surprised by this change.

r=me

[Brent Fulgham]

(In reply to comment #2)
> (From update of attachment 34483 [details])
> > +        * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove
> > +          manual flags and library dependencies for WinCairo port.
> I think a little more detail would be preferable here, given the difficulty of
> reading .vcproj diffs.
> > -				ForcedIncludeFiles="WebKitPrefix.h"
> >  				DisableSpecificWarnings="4819"
> > +				ForcedIncludeFiles="WebKitPrefix.h"
> I'm surprised by this change.
> r=me

I think this is just internal visual studio foo.  I'll see if I can avoid this change being committed by modifying the vcproj file manually.

[Brent Fulgham]

Landed in http://trac.webkit.org/changeset/46990