Summary: | Place More WinCairo Settings in vsprop files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Brent Fulgham
2009-08-06 10:31:18 PDT
Created attachment 34483 [details]
Move some settings into WinCairo/cURL vsprops files.
Comment on attachment 34483 [details] Move some settings into WinCairo/cURL vsprops files. > + * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove > + manual flags and library dependencies for WinCairo port. I think a little more detail would be preferable here, given the difficulty of reading .vcproj diffs. > - ForcedIncludeFiles="WebKitPrefix.h" > DisableSpecificWarnings="4819" > + ForcedIncludeFiles="WebKitPrefix.h" I'm surprised by this change. r=me (In reply to comment #2) > (From update of attachment 34483 [details]) > > + * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove > > + manual flags and library dependencies for WinCairo port. > I think a little more detail would be preferable here, given the difficulty of > reading .vcproj diffs. > > - ForcedIncludeFiles="WebKitPrefix.h" > > DisableSpecificWarnings="4819" > > + ForcedIncludeFiles="WebKitPrefix.h" > I'm surprised by this change. > r=me I think this is just internal visual studio foo. I'll see if I can avoid this change being committed by modifying the vcproj file manually. Landed in http://trac.webkit.org/changeset/46990 |