Bug 28005

Summary: Keypress should exit from pan scrolling mode
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebCore Misc.Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: adele
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Any Key Press none

Brian Weinstein
Reported 2009-08-04 16:50:06 PDT
Pressing a key should exit the WebView from pan scrolling mode. This matches what IE and Opera do. We currently exit the WebView on escape, matching Firefox, but this could be hard to discover for users who may have middle clicked on accident. <rdar://6591806>
Attachments
Any Key Press (2.04 KB, patch)
2009-08-04 16:54 PDT, Brian Weinstein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2009-08-04 16:54:46 PDT
Created attachment 34100 [details] Any Key Press
Adele Peterson
Comment 2 2009-08-04 17:16:12 PDT
Comment on attachment 34100 [details] Any Key Press What do other browsers that support pan scrolling do?
Brian Weinstein
Comment 3 2009-08-04 17:19:49 PDT
IE, Opera -> Exit pan scrolling on any keypress. Firefox -> Exit only on escape Safari, Chrome -> Exit only on escape - for now. From the radar (Steve): This is kind of nasty, since if a user accidently middle clicks on a webpage, they can't type until they left click or hit escape.
Adele Peterson
Comment 4 2009-08-04 17:23:16 PDT
Do IE and Opera also both cancel the pan scroll on keydown (instead of keyup)?
Brian Weinstein
Comment 5 2009-08-04 17:25:48 PDT
Yes, and Firefox cancels on escape down.
Brian Weinstein
Comment 6 2009-08-04 22:21:53 PDT
Clearing review flag - landed in http://trac.webkit.org/changeset/46793
Note You need to log in before you can comment on or make changes to this bug.