Summary: | [chromium] setting listeners on MessagePorts doesn't work in the worker process | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Abd-El-Malek <jam> | ||||
Component: | Platform | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
John Abd-El-Malek
2009-08-04 16:20:43 PDT
Created attachment 34098 [details]
Proposed patch
Comment on attachment 34098 [details] Proposed patch > + return PassRefPtr<EventListener>(); return 0; will work just fine, too. Why are we duplicating these in *Custom files? The logic is the same. Can we possibly use a template or generate these? If you're not up to mucking with this, can you file a bug about this? Assigned for landing. Comment on attachment 34098 [details] Proposed patch Clearing review flag on attachment: 34098 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/WorkerContextExecutionProxy.cpp M WebCore/bindings/v8/WorkerContextExecutionProxy.h M WebCore/bindings/v8/custom/V8MessagePortCustom.cpp Committed r46827 M WebCore/ChangeLog M WebCore/bindings/v8/WorkerContextExecutionProxy.cpp M WebCore/bindings/v8/WorkerContextExecutionProxy.h M WebCore/bindings/v8/custom/V8MessagePortCustom.cpp r46827 = 7956a160e452c6f261d5af9dc249b0854e5ed616 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46827 All reviewed patches have been landed. Closing bug. Thanks for committing. (In reply to comment #2) > (From update of attachment 34098 [details]) > > + return PassRefPtr<EventListener>(); > > return 0; > > will work just fine, too. ah, didn't know (I had just copied this section from the XHR custom bindings). > > Why are we duplicating these in *Custom files? The logic is the same. Can we > possibly use a template or generate these? Yeah a template should work. > If you're not up to mucking with this, can you file a bug about this? Sure: https://bugs.webkit.org/show_bug.cgi?id=28049 |