Bug 27972

Summary:

committer logic should be split out of bugzilla.py into its own module

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none
Patch v1	none
Updated to remove short_name code	abarth: review+

Eric Seidel (no email)

Reported 2009-08-04 00:22:20 PDT

committer logic should be split out of bugzilla.py into its own module Adam is going to need committer lookup abilities, so I've made it a module. I also finally learned how to write unit tests, so I unit tested all of my changes! Running the unit tests seems to be a tricky dance of setting up python paths correctly. Maybe one of the python gurus can help me straighten things out.

Attachments
Patch v1 (22.44 KB, patch) 2009-08-04 00:23 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch v1 (18.66 KB, patch) 2009-08-04 00:40 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Updated to remove short_name code (18.51 KB, patch) 2009-08-04 01:08 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-08-04 00:23:37 PDT

Created attachment 34040 [details] Patch v1

Eric Seidel (no email)

Comment 2 2009-08-04 00:40:02 PDT

Created attachment 34042 [details] Patch v1

Eric Seidel (no email)

Comment 3 2009-08-04 01:08:17 PDT

Created attachment 34044 [details] Updated to remove short_name code --- 5 files changed, 291 insertions(+), 63 deletions(-)

Adam Barth

Comment 4 2009-08-04 01:09:34 PDT

Comment on attachment 34044 [details] Updated to remove short_name code Thanks for adding the extra test. We should eventually have a test harness for all these tests.

Eric Seidel (no email)

Comment 5 2009-08-04 01:21:00 PDT

Landed as http://trac.webkit.org/changeset/46750. Unsure why the tool failed.

Note You need to log in before you can comment on or make changes to this bug.