Bug 279611

Summary:

[text-underline-position] Paint invalidation sometimes does not properly work

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, karlcow, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

BrowserCompat, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=70762

Attachments:

Description	Flags
Test reduction	none
Patch	none
Screen recording with the fix applied	none
[fast-cq]Patch	none

Tim Nguyen (:ntim)

Reported 2024-09-12 13:25:14 PDT

Set text-underline-position + text-decoration on this site: https://yitianshijie.vercel.app/2024/08/23/dragon-beard-cantonese-theatre-in-san-francisco The underline properly repaints after re-selection.

Attachments
Test reduction (291 bytes, text/html) 2024-09-12 16:07 PDT, alan	no flags	Details
Patch (3.61 KB, patch) 2024-09-13 12:50 PDT, alan	no flags	Details Formatted Diff Diff
Screen recording with the fix applied (3.29 MB, video/quicktime) 2024-09-13 12:57 PDT, alan	no flags	Details
[fast-cq]Patch (3.59 KB, patch) 2024-09-13 18:10 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2024-09-12 13:25:25 PDT

<rdar://problem/135904727>

alan

Comment 2 2024-09-12 16:07:53 PDT

Created attachment 472542 [details] Test reduction This looks to be about invalidating ink overflow area in vertical writing mode.

alan

Comment 3 2024-09-12 16:50:43 PDT

(In reply to zalan from comment #2) > Created attachment 472542 [details] > Test reduction > > This looks to be about invalidating ink overflow area in vertical writing > mode. when the content box has non-zero offset (e.g. through margin, border, padding)

alan

Comment 4 2024-09-12 20:19:21 PDT

This is the classic flipped block direction repaint bug (not specific to underline)

alan

Comment 5 2024-09-13 12:50:54 PDT

Created attachment 472550 [details] Patch

alan

Comment 6 2024-09-13 12:57:18 PDT

Created attachment 472551 [details] Screen recording with the fix applied

Simon Fraser (smfr)

Comment 7 2024-09-13 15:58:11 PDT

Comment on attachment 472550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=472550&action=review > COMMIT_MESSAGE:11 > +This is also inline with what we already do for content type of changes. Potential ambiguous use of "inline".

alan

Comment 8 2024-09-13 18:10:49 PDT

Created attachment 472553 [details] [fast-cq]Patch

EWS

Comment 9 2024-09-13 19:58:29 PDT

Committed 283666@main (9717bfc4323e): <https://commits.webkit.org/283666@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 472553 [details].

EWS

Comment 10 2024-09-18 16:38:03 PDT

Committed 283286.77@safari-7620-branch (958d1f6cae4e): <https://commits.webkit.org/283286.77@safari-7620-branch> Reviewed commits have been landed. Closing PR #1828 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.