Bug 27958

Summary: WAI-ARIA: Implement 'aria-required' attribute.
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch jhoneycutt: review+

chris fleizach
Reported 2009-08-03 15:53:47 PDT
Implement 'aria-required' attribute.
Attachments
patch (16.28 KB, patch)
2009-08-03 16:16 PDT, chris fleizach 		jhoneycutt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2009-08-03 16:16:11 PDT
Created attachment 34015 [details] patch
Jon Honeycutt
Comment 2 2009-08-03 22:39:35 PDT
Comment on attachment 34015 [details] patch > Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp > =================================================================== > --- WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp (revision 46735) > +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp (working copy) > @@ -327,6 +327,11 @@ static JSValueRef getIsEnabledCallback(J > return JSValueMakeBoolean(context, toAXElement(thisObject)->isEnabled()); > } > > +static JSValueRef getIsRequiredCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception) > +{ > + return JSValueMakeBoolean(context, toAXElement(thisObject)->isRequired()); > +} > + No need to name the unused params. > Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h > =================================================================== > --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h (revision 46735) > +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h (working copy) > @@ -95,6 +95,7 @@ public: > JSStringRef selectedTextRange(); > bool supportsPressAction(); > bool isEnabled(); > + bool isRequired(); > double clickPointX(); > double clickPointY(); > Looks like this can be const. r=me
chris fleizach
Comment 3 2009-08-04 09:15:36 PDT
http://trac.webkit.org/changeset/46768
Note You need to log in before you can comment on or make changes to this bug.