Summary: | [Gtk] macros in webkit.m4 should be defined once only | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||||
Component: | WebKitGTK | Assignee: | Jan Alonzo <jmalonzo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Jan Alonzo
2009-08-02 00:23:52 PDT
Created attachment 33946 [details]
Patch v1
Comment on attachment 33946 [details]
Patch v1
Just gonna trust you here. rs=me.
(In reply to comment #2) > (From update of attachment 33946 [details]) > Just gonna trust you here. rs=me. Thank you. Landed as http://trac.webkit.org/changeset/46714 and 46715. I had to revert this, since it was making us build debug images by default... Comment on attachment 33946 [details]
Patch v1
Clearing flags.
(In reply to comment #4) > I had to revert this, since it was making us build debug images by default... Without this patch -g still gets passed on my machine. Are you sure it's this patch that made it build debug images? (In reply to comment #6) > (In reply to comment #4) > > I had to revert this, since it was making us build debug images by default... > > Without this patch -g still gets passed on my machine. Are you sure it's this > patch that made it build debug images? Reverting it worked on my machine, but I guess you can never be sure of anything with autotools :) (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > I had to revert this, since it was making us build debug images by default... > > > > Without this patch -g still gets passed on my machine. Are you sure it's this > > patch that made it build debug images? > > Reverting it worked on my machine, but I guess you can never be sure of > anything with autotools :) The issue here seems to be that AC_PROG_CXX gets expanded before we're able to set CXXFLAGS and CFLAGS (AC_PROG_CXX adds "-g -O2" if CXXFLAGS/CFLAGS are not defined). So we need to make sure those flags are set before AC_PROG_CXX is expanded. Created attachment 34126 [details]
Patch v1
Comment on attachment 34126 [details]
Patch v1
OK, makes sense :)
(In reply to comment #10) > (From update of attachment 34126 [details]) > OK, makes sense :) Landed as http://trac.webkit.org/changeset/46797. Thanks! |