Bug 27929

Summary: [Gtk] macros in webkit.m4 should be defined once only
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Jan Alonzo <jmalonzo>
Status: RESOLVED FIXED    
Severity: Normal CC: xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch v1
none
Patch v1 xan.lopez: review+

Jan Alonzo
Reported 2009-08-02 00:23:52 PDT
Macros like WEBKIT_INIT, WEBKIT_CHECK_DEPENDENCIES, etc... should be defined once only as they're not meant to be called multiple times.
Attachments
Patch v1 (1.89 KB, patch)
2009-08-02 00:28 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
Patch v1 (2.83 KB, patch)
2009-08-05 04:24 PDT, Jan Alonzo 		xan.lopez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-08-02 00:28:15 PDT
Created attachment 33946 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-08-02 15:08:02 PDT
Comment on attachment 33946 [details] Patch v1 Just gonna trust you here. rs=me.
Jan Alonzo
Comment 3 2009-08-03 03:50:34 PDT
(In reply to comment #2) > (From update of attachment 33946 [details]) > Just gonna trust you here. rs=me. Thank you. Landed as http://trac.webkit.org/changeset/46714 and 46715.
Xan Lopez
Comment 4 2009-08-05 01:14:33 PDT
I had to revert this, since it was making us build debug images by default...
Xan Lopez
Comment 5 2009-08-05 01:14:51 PDT
Comment on attachment 33946 [details] Patch v1 Clearing flags.
Jan Alonzo
Comment 6 2009-08-05 03:35:46 PDT
(In reply to comment #4) > I had to revert this, since it was making us build debug images by default... Without this patch -g still gets passed on my machine. Are you sure it's this patch that made it build debug images?
Xan Lopez
Comment 7 2009-08-05 03:37:58 PDT
(In reply to comment #6) > (In reply to comment #4) > > I had to revert this, since it was making us build debug images by default... > > Without this patch -g still gets passed on my machine. Are you sure it's this > patch that made it build debug images? Reverting it worked on my machine, but I guess you can never be sure of anything with autotools :)
Jan Alonzo
Comment 8 2009-08-05 04:07:03 PDT
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > I had to revert this, since it was making us build debug images by default... > > > > Without this patch -g still gets passed on my machine. Are you sure it's this > > patch that made it build debug images? > > Reverting it worked on my machine, but I guess you can never be sure of > anything with autotools :) The issue here seems to be that AC_PROG_CXX gets expanded before we're able to set CXXFLAGS and CFLAGS (AC_PROG_CXX adds "-g -O2" if CXXFLAGS/CFLAGS are not defined). So we need to make sure those flags are set before AC_PROG_CXX is expanded.
Jan Alonzo
Comment 9 2009-08-05 04:24:40 PDT
Created attachment 34126 [details] Patch v1
Xan Lopez
Comment 10 2009-08-05 04:32:47 PDT
Comment on attachment 34126 [details] Patch v1 OK, makes sense :)
Jan Alonzo
Comment 11 2009-08-05 04:41:08 PDT
(In reply to comment #10) > (From update of attachment 34126 [details]) > OK, makes sense :) Landed as http://trac.webkit.org/changeset/46797. Thanks!
Note You need to log in before you can comment on or make changes to this bug.