Bug 279237
| Summary: | Mark the unused _fullScreenEnabled SPI as deprecated | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit API | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
No one should be using the WKPreference class's '_fullScreenEnabled' property. This is no longer used, in favor of 'elementFullscreenEnabled'.
I noticed that some older tests still use the deprecated version of this property, so corrected those tests to match.
There should be no behavior changes with this correction, since both properties internally modified the same state variable used to control the actual feature.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/135380328>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/33219
EWS
Committed 283360@main (02078e1966d8): <https://commits.webkit.org/283360@main>
Reviewed commits have been landed. Closing PR #33219 and removing active labels.
Brent Fulgham
Re-opening for pull request https://github.com/WebKit/WebKit/pull/33353
EWS
Committed 283421@main (c732501888aa): <https://commits.webkit.org/283421@main>
Reviewed commits have been landed. Closing PR #33353 and removing active labels.