Bug 279233
| Summary: | Rename BlockFlowDirection to FlowDirection for better re-use | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | Layout and Rendering | Assignee: | fantasai <fantasai.bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
fantasai
We currently have a BlockFlowDirection enum for returning the block flow direction:
enum class BlockFlowDirection : uint8_t {
TopToBottom,
BottomToTop,
LeftToRight,
RightToLeft,
};
Renaming it to FlowDirection would allow it to be re-used in additional contexts that need a flow direction--which would also mean that utility functions that compute against it can also be re-used. It's also slightly shorter, so lines using its literals are less likely to wrap awkwardly.
The fact that it's about the block axis is generally clear from e.g. the variable names, so we're lot losing any clarity by doing this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/135376714>
fantasai
Pull request: https://github.com/WebKit/WebKit/pull/33216
EWS
Committed 283249@main (2c4181eb99b6): <https://commits.webkit.org/283249@main>
Reviewed commits have been landed. Closing PR #33216 and removing active labels.