Right click on timeline of media controls panel cause seek

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Hin-Chung Lam]

Steps to reproduce the bug:
1. Open a page with <video controls src="something"></video>
2. Play the movie
3. Right click on the time bar

Expected behavior:
Nothing should happen

Actual behavior:
Seeked to the current playback position.


So the result is that if you right click many many times, you will seek to the current playback position over and over again.

[Hin-Chung Lam]

Created attachment 33934 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 33934 [details]
patch

Looks fine.

Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button.

Style viloation:
1                 if (window.eventSender)
 12                 {

If you were a committer I would just r+ and you could fix this when landing.  Since I don't think you are, please re-post with the two above fixes

[Eric Seidel (no email)]

Comment on attachment 33934 [details]
patch

Looks fine.

Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button.

Style viloation:
1                 if (window.eventSender)
 12                 {

If you were a committer I would just r+ and you could fix this when landing.  Since I don't think you are, please re-post with the two above fixes

[Hin-Chung Lam]

Created attachment 34256 [details]
patch

[Hin-Chung Lam]

Created attachment 34257 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 34257 [details]
patch

LGTM!  Thanks!

[Hin-Chung Lam]

Thanks for the review!

[Albert J. Wong]

Committed as http://trac.webkit.org/changeset/46915.

[Simon Fraser (smfr)]

This caused a bad regression in mouse handling (bug 28211). Please address as soon as possible, or revert this change.

[Hin-Chung Lam]

I'm looking into the regression now.