Bug 27915

Summary: [commit+] Add a top level build option to control datagrid support
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch. none

Description Laszlo Gombos 2009-07-31 20:58:43 PDT 
Turn on datagrid support on by default in build-webkit. By adding the option to control datagrid support will also enable the --minimal option to turn datagrid option off.
Comment 1 Laszlo Gombos 2009-07-31 21:03:01 PDT 
Created attachment 33928 [details]
proposed patch.
Comment 2 Eric Seidel (no email) 2009-07-31 21:21:20 PDT 
Comment on attachment 33928 [details]
proposed patch.

OK.
Comment 3 Eric Seidel (no email) 2009-07-31 21:22:00 PDT 
Comment on attachment 33928 [details]
proposed patch.

Should datagrid be on by default?
Comment 4 Laszlo Gombos 2009-07-31 21:30:04 PDT 
(In reply to comment #3)
> (From update of attachment 33928 [details])
> Should datagrid be on by default?

Eric, thanks for the review. I think I have it on by default in the patch.

define => "ENABLE_DATAGRID", default => 1
Comment 5 Adam Barth 2009-07-31 23:29:48 PDT 
Comment on attachment 33928 [details]
proposed patch.

Clearing review flag on attachment: 33928

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/build-webkit
Committed r46662
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/build-webkit
r46662 = 4350e2dffbf736a02d1b8fa1509acffa1b61fbc4 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46662
Comment 6 Adam Barth 2009-07-31 23:29:51 PDT 
All reviewed patches have been landed.  Closing bug.