Bug 279125
| Summary: | Simplify `isSVGRenderer()` in `RenderObject.h` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
Just noticed following in RenderObject.h:
WebKit Source: https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/rendering/RenderObject.h#602
Current:
bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isLegacyRenderSVGModelObject() || isRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); }
Where:
isLegacyRenderSVGModelObject() || isRenderSVGModelObject() -> can be replaced with (isRenderOrLegacyRenderSVGModelObject())
Which in turn will make `isSVGRenderer` as:
bool isSVGRenderer() const { return isRenderOrLegacyRenderSVGRoot() || isRenderOrLegacyRenderSVGModelObject() || isRenderSVGBlock() || isRenderSVGInline(); }
___
Just raising so we can do this clean-up.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fady Farag
Pull request: https://github.com/WebKit/WebKit/pull/33147
EWS
Committed 283279@main (78a12607073a): <https://commits.webkit.org/283279@main>
Reviewed commits have been landed. Closing PR #33147 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/135442411>