Bug 27908

Summary: check-webkit-style --git-commit has bugs if you select a commit in the past
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, eric, manyoso
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix.
none
Proposed fix. manyoso: review+

David Levin
Reported 2009-07-31 18:44:39 PDT
check-wekbit-style uses the diff on the single commit to get the lines changes so it can filter error messages. The problem is that the lines changed in the commit may have moved since the commit was done, so the filtering is incorrect. This fix is uses the commit given as the starting point and the current directory state as the ending point.
Attachments
Proposed fix. (4.33 KB, patch)
2009-07-31 18:56 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
Proposed fix. (4.34 KB, patch)
2009-07-31 19:22 PDT, David Levin 		manyoso: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-07-31 18:56:56 PDT
Created attachment 33919 [details] Proposed fix.
Adam Treat
Comment 2 2009-07-31 19:07:13 PDT
Comment on attachment 33919 [details] Proposed fix. > + commitish = flags["--git-commit"] > + if commitish.find('..'): > + # FIXME: If the range is a "...", the code should find the common ancesto, > + # do the diff from there. Not sure I understand this FIXME. And you mean 'ancestoR', right?
David Levin
Comment 3 2009-07-31 19:22:28 PDT
Created attachment 33921 [details] Proposed fix. Addressed some coding issues mention by Eric. Fixed the spelling issue and tried to clarify the issue mentioned by Adam.
David Levin
Comment 4 2009-07-31 19:36:56 PDT
http://trac.webkit.org/changeset/46652
Note You need to log in before you can comment on or make changes to this bug.