Bug 27898

Summary: Migrate new localStorage layout tests over to sessionStorage
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch v1 eric: review-

Jeremy Orlow
Reported 2009-07-31 15:52:42 PDT
The localStorage side of this work was done in https://bugs.webkit.org/show_bug.cgi?id=27778
Attachments
Patch v1 (31.71 KB, patch)
2009-07-31 16:25 PDT, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch v1 (31.71 KB, patch)
2009-07-31 16:55 PDT, Jeremy Orlow 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-07-31 16:25:56 PDT
Created attachment 33906 [details] Patch v1
Eric Seidel (no email)
Comment 2 2009-07-31 16:32:18 PDT
Comment on attachment 33906 [details] Patch v1 In general it's better to have the test expectations in the tests themselves, instead of depending on logging. That's why we have the shouldBe* functions as part of the js testing framework.
Jeremy Orlow
Comment 3 2009-07-31 16:35:03 PDT
I have https://bugs.webkit.org/show_bug.cgi?id=27897 filed against myself to switch all the dom storage stuff over. In mean time, I was hoping to keep SessionStorage and LocalStorage in parity.
Jeremy Orlow
Comment 4 2009-07-31 16:55:53 PDT
Created attachment 33907 [details] Patch v1
Eric Seidel (no email)
Comment 5 2009-08-06 17:53:39 PDT
Comment on attachment 33907 [details] Patch v1 If these are literally copy/paste from teh localSTorage tests, why wouldn't we want to just turn them into funcitons/js files which we could just pass a "storage" object into? In general I'm very against copy paste. :( r- for now, while waiting for your reply. Feel free to set it back to r=?
Jeremy Orlow
Comment 6 2009-08-06 17:55:31 PDT
Agreed. There's another cleanup bug for this stuff. I'll factor it all out and do the cleanup as a part of that.
Note You need to log in before you can comment on or make changes to this bug.