Bug 27896

Summary: Favicons are still loaded when automatic image loading is disabled.
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fix, DRT enhancements, and layout test. sullivan: review+

Brady Eidson
Reported 2009-07-31 15:37:45 PDT
Favicons are still loaded when automatic image loading is disabled.
Attachments
Fix, DRT enhancements, and layout test. (12.60 KB, patch)
2009-07-31 15:59 PDT, Brady Eidson 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2009-07-31 15:37:59 PDT
In radar as <rdar://problem/6973106>
Brady Eidson
Comment 2 2009-07-31 15:59:17 PDT
Created attachment 33905 [details] Fix, DRT enhancements, and layout test.
John Sullivan
Comment 3 2009-07-31 16:13:44 PDT
Comment on attachment 33905 [details] Fix, DRT enhancements, and layout test. Maybe add a line that explains why site icons are tied together with images on the page in this way, such as "People who want to avoid loading images generally want to avoid loading all images."
Brady Eidson
Comment 4 2009-07-31 16:22:32 PDT
Sending LayoutTests/ChangeLog Adding LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt Adding LayoutTests/http/tests/misc/favicon-loads-with-images-disabled.html Sending WebCore/ChangeLog Sending WebCore/loader/FrameLoader.cpp Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/LayoutTestController.cpp Sending WebKitTools/DumpRenderTree/LayoutTestController.h Sending WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp Sending WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm Sending WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm Sending WebKitTools/DumpRenderTree/qt/jsobjects.cpp Sending WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp Sending WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp Transmitting file data .............. Committed revision 46646.
Note You need to log in before you can comment on or make changes to this bug.