Summary: | bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2009-07-31 13:31:05 PDT
Created attachment 33901 [details]
Patch v1
Comment on attachment 33901 [details]
Patch v1
LGTM. Are there other places we need to worry about? We have several places we set the comment... r=me to change the rest too.
This was actually caused by bugzilla 3.0 iirc. I swear I fixed one of these before. :) (In reply to comment #2) > (From update of attachment 33901 [details]) > LGTM. Are there other places we need to worry about? We have several places > we set the comment... r=me to change the rest too. These were the only two on the attachments.cgi?action=edit pages that I saw. Comment on attachment 33901 [details]
Patch v1
I only saw one in your change, but I assume I must have fixed the other one before (or someone did) and forgot to fix this one! eep! :) Thanks again.
$ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r46640 http://trac.webkit.org/changeset/46640 |