Bug 27886

Summary:

Build QtWebKit without benchmark tests for Qt < 4.5

Product:

WebKit

Reporter:

Jakob Petsovits <jpetsovits>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Build QtWebKit without benchmark tests for Qt < 4.5	none
Build QtWebKit without benchmark tests for Qt < 4.5 (try 2)	manyoso: review+

Jakob Petsovits

Reported 2009-07-31 09:36:24 PDT

On one of my systems, I accidentally had Qt 4.4 installed, and decided to build the Qt port there. The QBENCHMARK macro is only available from 4.5 on though, and test files making use of QBENCHMARK are included unconditionally at the moment. The patch below fixes this, and makes WebKit/qt/tests compile with 4.4 again.

Attachments
Build QtWebKit without benchmark tests for Qt < 4.5 (1.09 KB, patch) 2009-07-31 09:40 PDT, Jakob Petsovits	no flags	Details Formatted Diff Diff
Build QtWebKit without benchmark tests for Qt < 4.5 (try 2) (1.09 KB, patch) 2009-07-31 09:43 PDT, Jakob Petsovits	manyoso: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jakob Petsovits

Comment 1 2009-07-31 09:40:24 PDT

Created attachment 33883 [details] Build QtWebKit without benchmark tests for Qt < 4.5

Jakob Petsovits

Comment 2 2009-07-31 09:43:10 PDT

Created attachment 33884 [details] Build QtWebKit without benchmark tests for Qt < 4.5 (try 2) Don't end a sentence with two periods, only one.

Jakob Petsovits

Comment 3 2009-07-31 09:55:35 PDT

Landed by Kenneth Rohde Christiansen with r46632.

Note You need to log in before you can comment on or make changes to this bug.