Bug 27870

Summary: isContentEditable function in htmlediting.* can be removed
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, justin.garcia
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
removes the function adele: review+

Ryosuke Niwa
Reported 2009-07-31 00:56:16 PDT
isContentEditable function is added in http://trac.webkit.org/changeset/19452 to accomplish enclosingNodeOfType(node, &isContentEditable) but this seems to be equivalent to node->isContentEditable() today.
Attachments
removes the function (6.41 KB, patch)
2009-07-31 11:24 PDT, Ryosuke Niwa 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2009-07-31 11:24:51 PDT
Created attachment 33889 [details] removes the function
Adele Peterson
Comment 2 2009-07-31 11:32:09 PDT
Comment on attachment 33889 [details] removes the function My only comment is that the title of this bug could be "isContentEditable function in htmlediting.* can be removed" instead of "must", but that doesn't really matter.
Justin Garcia
Comment 3 2009-07-31 11:45:21 PDT
Clarified with Ryosuke. We're only ever using enclosingNodeOfType(node, &isContentEditable) to determine the editability of node. So it's OK to remove.
Ryosuke Niwa
Comment 4 2009-08-01 23:52:12 PDT
Landed in http://trac.webkit.org/changeset/46681.
Note You need to log in before you can comment on or make changes to this bug.