Bug 27870

Summary:

isContentEditable function in htmlediting.* can be removed

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, justin.garcia

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
removes the function	adele: review+

Description Ryosuke Niwa 2009-07-31 00:56:16 PDT

isContentEditable function is added in http://trac.webkit.org/changeset/19452 to accomplish
enclosingNodeOfType(node, &isContentEditable)
but this seems to be equivalent to node->isContentEditable() today.

Comment 1 Ryosuke Niwa 2009-07-31 11:24:51 PDT

Created attachment 33889 [details]
removes the function

Comment 2 Adele Peterson 2009-07-31 11:32:09 PDT

Comment on attachment 33889 [details]
removes the function

My only comment is that the title of this bug could be "isContentEditable function in htmlediting.* can be removed" instead of "must", but that doesn't really matter.

Comment 3 Justin Garcia 2009-07-31 11:45:21 PDT

Clarified with Ryosuke.  We're only ever using enclosingNodeOfType(node, &isContentEditable) to determine the editability of node.  So it's OK to remove.

Comment 4 Ryosuke Niwa 2009-08-01 23:52:12 PDT

Landed in http://trac.webkit.org/changeset/46681.