Bug 27865

Summary: selectionHasStyle needs clean up to fix Bug 27858
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Blocker CC: eric, justin.garcia
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27858    
Attachments:
Description Flags
cleans up selectionHasStyle and selectionStartHasStyle
none
deleted irrelevant tests.
none
fixed typo
none
Added the reason this patch does not need tests eric: review+

Ryosuke Niwa
Reported 2009-07-30 18:54:43 PDT
ditto.
Attachments
cleans up selectionHasStyle and selectionStartHasStyle (61.66 KB, patch)
2009-07-30 19:03 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
deleted irrelevant tests. (6.79 KB, patch)
2009-07-30 19:04 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
fixed typo (6.76 KB, patch)
2009-07-30 19:10 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added the reason this patch does not need tests (8.10 KB, patch)
2009-07-31 18:35 PDT, Ryosuke Niwa 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2009-07-30 19:03:25 PDT
Created attachment 33853 [details] cleans up selectionHasStyle and selectionStartHasStyle
Ryosuke Niwa
Comment 2 2009-07-30 19:04:52 PDT
Created attachment 33854 [details] deleted irrelevant tests.
Ryosuke Niwa
Comment 3 2009-07-30 19:10:14 PDT
Created attachment 33855 [details] fixed typo
Eric Seidel (no email)
Comment 4 2009-07-31 14:16:44 PDT
Comment on attachment 33855 [details] fixed typo + The change is not testable. Why? Because there are no functional changes? You should say that.
Ryosuke Niwa
Comment 5 2009-07-31 18:35:50 PDT
Created attachment 33917 [details] Added the reason this patch does not need tests
Eric Seidel (no email)
Comment 6 2009-08-03 17:39:15 PDT
Comment on attachment 33917 [details] Added the reason this patch does not need tests OK.
Ryosuke Niwa
Comment 7 2009-08-04 00:33:46 PDT
Landed in http://trac.webkit.org/changeset/46749.
Note You need to log in before you can comment on or make changes to this bug.