Bug 27861

Summary: [commit+] [Chromium] remove ChromeClientChromium::setToolTip()
Product: WebKit Reporter: Xiaomei Ji <xji>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
patch mitz: review+

Xiaomei Ji
Reported 2009-07-30 15:42:11 PDT
This is a follow-up of Webkit patch for issue 24187 -- RTL: tooltip does not get its directionality from its element's directionality. In the above patch, Webkit passed in both tooltip text and its element directionality to client. To make Chromium build OK after the signature change in Webkit, an overloaded virtual function ChromeClientChromium::setToolTip(const String&, TextDirection) was introduced. Now since Chrome changed its signature in its Webkit glue layer (ChromeClientImpl::setToolTip()), the overloaded ChromeClientChromium::setToolTip() is no longer needed.
Attachments
patch (1.41 KB, patch)
2009-07-30 16:00 PDT, Xiaomei Ji 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xiaomei Ji
Comment 1 2009-07-30 16:00:13 PDT
Created attachment 33847 [details] patch
Adam Barth
Comment 2 2009-07-31 23:11:04 PDT
Appears to have already been landed. Please close the bug when you land something.
Note You need to log in before you can comment on or make changes to this bug.