Bug 278575
| Summary: | Use `=default` for destructors in `rendering` code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
SSIA
We have bunch of these:
RenderListMarker::~RenderListMarker()
{
// Do not add any code here. Add it to willBeDestroyed() instead.
}
I think we should align with other code base and just change them to:
// Do not add any code in below destructor. Add it to willBeDestroyed() instead.
RenderVideo::~RenderVideo() = default;
Just a reference.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/134586310>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/32643
EWS
Committed 282685@main (bc7d339835a5): <https://commits.webkit.org/282685@main>
Reviewed commits have been landed. Closing PR #32643 and removing active labels.