Bug 278529
| Summary: | [webkitpy] Add LTR and RTL to list of allowed common enum abbreviations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Christian Liebel <christian> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Christian Liebel
check-webkit-style does not allow the values "LTR" and "RTL" to appear in enums (rule "readability/enum_casing"):
> enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.
In a pull request, it was discussed that the allowlist should include those two values:
* https://github.com/WebKit/WebKit/pull/30634#discussion_r1723324893
* https://github.com/WebKit/WebKit/pull/30634#discussion_r1727244189
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Christian Liebel
Pull request: https://github.com/WebKit/WebKit/pull/32598
Radar WebKit Bug Importer
<rdar://problem/134949318>
EWS
Committed 295803@main (f5f1f02036a7): <https://commits.webkit.org/295803@main>
Reviewed commits have been landed. Closing PR #32598 and removing active labels.