Add --minimal option to webkit-build

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jakob Petsovits]

Instead of disabling all optional features with --no-svg, --no-video, --no-xslt, etc., it would be nice to disable all of those at once and only get those options that were explicitely enabled. My relationship to Perl is not the most loving one, but here's a patch anyways. Please review, thanks!

[Jakob Petsovits]

Created attachment 33807 [details]
Add --minimal option to webkit-build

[Jakob Petsovits]

Created attachment 33808 [details]
Add --minimal option to webkit-build (try 2)

New version, this one gets the --minimal option out of @ARGV and thus makes it work with subsequent code that makes use of @ARGV still, like Qt's qmake stuff.

[Jakob Petsovits]

Created attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

Fix for a spelling issue, pointed out by Adam Treat: explicitely -> explicitly.

[Adam Roben (:aroben)]

Comment on attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

I think it would be better and clearer for --minimal to be parsed like all the other options. After the GetOptions call, if $minimal is true you can just loop over @features and set all the values that don't match the default to 0.

[Adam Roben (:aroben)]

Comment on attachment 33812 [details]
Add --minimal option to webkit-build (try 3)

Jakob convinced me that my suggested approach is not better.

r=me

[Adam Treat]

Landed with r46597.