Summary: | MessageEvent should not be cancelable by default | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||
Component: | WebCore JavaScript | Assignee: | Andrew Wilson <atwilson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Andrew Wilson
2009-07-30 11:58:10 PDT
Created attachment 39583 [details]
proposed patch
Comment on attachment 39583 [details]
proposed patch
Rejecting patch 39583 from commit-queue.
This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment on attachment 39583 [details] proposed patch media/video-source-error.html -> timed out You've been bit by flakey media tests. :( bug 28624. Hopefully I'll get a chance to look at fixing that after perf stuff today. OK, I'm ready to manually commit it anyway - if the commit-queue fails again I'll just manually commit. When I get a commit-queue failure, is there any way for me to tell what the failure was? Comment on attachment 39583 [details]
proposed patch
Rejecting patch 39583 from commit-queue.
This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Maybe that was flakey? I think it might be related... |